Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Embrace to vendors list #4227

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add Embrace to vendors list #4227

merged 2 commits into from
Apr 8, 2024

Conversation

davidlawrencer
Copy link
Contributor

@davidlawrencer davidlawrencer commented Apr 1, 2024 •
edited
Loading

Adds Embrace to the list of vendors who natively support OpenTelemetry.

@davidlawrencer davidlawrencer requested a review from a team April 1, 2024 17:44
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 1, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: davidlawrencer / name: David Rifkin (0e4a73d)
  • ✅ login: svrnm / name: Severin Neumann (9e1ebe7)

chalin
chalin reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO your entry would fit more approriately under integrations, not a vendor (see the vendor page for details). But I'll let the other maintainers comment on this when they back from PTO.

Also note that I've submitted some minor suggested copyedits to your Getting started page: embrace-io/embrace-apple-sdk#3

@svrnm
Copy link
Member

svrnm commented Apr 8, 2024

IMHO your entry would fit more approriately under integrations, not a vendor (see the vendor page for details). But I'll let the other maintainers comment on this when they back from PTO.

Also note that I've submitted some minor suggested copyedits to your Getting started page: embrace-io/embrace-apple-sdk#3

From the website embrace.io this looks like a vendor providing observability/monitoring capabilities, so I think this is the right spot.

@svrnm svrnm merged commit 2f8c2de into open-telemetry:main Apr 8, 2024
14 checks passed
@davidlawrencer davidlawrencer deleted the add-embrace-vendor-list branch April 8, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@theletterf theletterf theletterf approved these changes

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidlawrencer @svrnm @theletterf @chalin